Skip to content

Fix missing prettyPrint overloads in header and implementation #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ActualMasterOogway wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing prettyPrint overloads in header and implementation #2209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Ast/include/Luau/PrettyPrinter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ void dump(AstNode* node);

// Never fails on a well-formed AST
std::string prettyPrint(AstStatBlock& ast);
std::string prettyPrint(AstStatBlock& block, const CstNodeMap& cstNodeMap);
std::string prettyPrintWithTypes(AstStatBlock& block);
std::string prettyPrintWithTypes(AstStatBlock& block, const CstNodeMap& cstNodeMap);

Expand Down
5 changes: 5 additions & 0 deletions Ast/src/PrettyPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1966,6 +1966,11 @@ std::string prettyPrint(AstStatBlock& block, const CstNodeMap& cstNodeMap)
return writer.str();
}

std::string prettyPrint(AstStatBlock& block)
{
return prettyPrint(block, CstNodeMap{nullptr});
}

std::string prettyPrintWithTypes(AstStatBlock& block, const CstNodeMap& cstNodeMap)
{
StringWriter writer;
Expand Down
13 changes: 13 additions & 0 deletions tests/PrettyPrinter.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,19 @@ end
CHECK_EQ(example, prettyPrint(example).code);
}

TEST_CASE("prettyPrint_AstStatBlock_overload")
{
const std::string code = "local a = 1";
ParseOptions options;
Allocator allocator;
AstNameTable names(allocator);
ParseResult result = Parser::parse(code.c_str(), code.size(), names, allocator, options);
REQUIRE(result.root != nullptr);

std::string printed = prettyPrint(*result.root);
CHECK_EQ("local a = 1", printed);
}

TEST_CASE("string_literals")
{
const std::string code = R"( local S='abcdef\n\f\a\020' )";
Expand Down