Determine data class repr sizes programatically#5
Open
Wheest wants to merge 7 commits intoluchris429:mainfrom
Open
Determine data class repr sizes programatically#5Wheest wants to merge 7 commits intoluchris429:mainfrom
Wheest wants to merge 7 commits intoluchris429:mainfrom
Conversation
Improve formatting and workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, this PR builds off of #4, so the diff will be way smaller if that is merged.
The reason for this feature is that in a few places the representation size of things like the number of actions and the terrain is hard-coded. This violates DRY principles, since if we, for example, add a new action, then we need to update this in a few places.
This PR fixes this by adding a property to the
TerrainStateandActiondataclasses that returns therepr_size.There may be other places where this can be applied, but so far I'm only touching things exposed by my own modifications.