Remove old DDP, FSDP, and DeepSpeed distributed strategies#4097
Merged
w4nderlust merged 4 commits intomainfrom Apr 12, 2026
Merged
Remove old DDP, FSDP, and DeepSpeed distributed strategies#4097w4nderlust merged 4 commits intomainfrom
w4nderlust merged 4 commits intomainfrom
Conversation
Test Results 10 files +1 10 suites +1 1h 47m 2s ⏱️ + 1m 9s Results for commit 5c83ef7. ± Comparison against base commit 4a10993. This pull request removes 2 and adds 9 tests. Note that renamed tests count towards both.This pull request removes 1 skipped test and adds 4 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Replace the legacy DDPStrategy, FSDPStrategy, and DeepSpeedStrategy classes with the unified AccelerateStrategy as the primary distributed training backend. HuggingFace Accelerate provides a single abstraction that handles DDP, FSDP, and DeepSpeed via configuration rather than separate class hierarchies. - Delete ludwig/distributed/ddp.py, fsdp.py, deepspeed.py - Delete ludwig/backend/deepspeed.py and DataParallelBackend base class - Remove registry entries for "ddp", "fsdp", "deepspeed" strategies - Remove "deepspeed" backend type and its factory - Update default strategy from "ddp" to "accelerate" - Update config validation for LLM finetuning to require "accelerate" - Update all test references from "ddp"/"deepspeed" to "accelerate" - Clean up DeepSpeed-specific comments throughout codebase
2da1cd4 to
1f1f985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DDPStrategy,FSDPStrategy, andDeepSpeedStrategyclasses along with theDeepSpeedBackendandDataParallelBackend, replacing them with the unifiedAccelerateStrategyas the sole distributed training backend"ddp"to"accelerate"and updates all config validation, tests, and comments accordinglyfsdp_config,deepspeed_configparams) rather than separate class hierarchiesFiles deleted
ludwig/distributed/ddp.pyludwig/distributed/fsdp.pyludwig/distributed/deepspeed.pyludwig/backend/deepspeed.pyTest plan
strategy: accelerateacceleratestrategy