Skip to content

Use const instead of var for math constants #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use const instead of var for math constants #116

wants to merge 1 commit into from

Conversation

@dmitrygusev
Copy link

@dmitrygusev dmitrygusev commented Feb 19, 2017

No description provided.

@FlorianWendelborn
Copy link

FlorianWendelborn commented Feb 19, 2017

Actually IMO there is no reason to use var for anything anymore. I personally consider it to be obsolete/deprecated in favor of const / let.

xtuc
xtuc approved these changes Feb 19, 2017
View reviewed changes
Copy link

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying that pi is a variable doesn't make sense anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@FlorianWendelborn FlorianWendelborn FlorianWendelborn approved these changes

@xtuc xtuc xtuc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmitrygusev @FlorianWendelborn @mathiasbynens @xtuc