Refactor customization rendering in capabilities.md#26
Open
Ludovic-Iafrate wants to merge 1 commit into
Open
Conversation
Wrong render() API call in both code examples — lines 101–110 and 117–131
Both examples under "Usage Example" and "Checking User Authentication Status" use:
render(targets.HEADER, placement.AFTER, components.Message({...}));
Problems:
- placement.AFTER doesn't exist — the valid values are ABOVE, UNDER, LEFT, RIGHT, REPLACE
- Wrong call signature — render() takes an object { placement, target, toRender }, not positional arguments
- constants is missing from the destructuring — const { Kind } = constants; is used inside but constants is not in ({ render, targets, placement, components })
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrong render() API call in both code examples — lines 101–110 and 117–131
Both examples under "Usage Example" and "Checking User Authentication Status" use: render(targets.HEADER, placement.AFTER, components.Message({...}));
Problems: