file attribute disk-directory#2453
Open
Huncsuga wants to merge 6 commits into
Open
Conversation
Sync 05.10.2025
Sync 14.12.2025
Huncsuga
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for configuring the storage disk and upload directory for the File attribute field type, so FileUpload can store files in a configurable location.
Changes:
- Extend core File field type configuration schema to include
diskanddirectory. - Update Admin File field type converter to apply
disk/directoryto FilamentFileUpload, and expose configuration UI fields. - Add translations for the new configuration labels across supported locales.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/FieldTypes/File.php | Adds disk and directory to the File field type config schema. |
| packages/admin/src/Support/FieldTypes/File.php | Applies configured disk/directory to FileUpload and adds configuration form fields. |
| packages/admin/resources/lang/ar/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/bg/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/de/fieldtypes.php | Adds File field form labels including disk / directory. |
| packages/admin/resources/lang/en/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/es/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/fa/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/fr/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/hu/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/nl/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/pl/fieldtypes.php | Adds File field form labels including disk / directory. |
| packages/admin/resources/lang/pt_BR/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/ro/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/tr/fieldtypes.php | Adds disk / directory labels. |
| packages/admin/resources/lang/vi/fieldtypes.php | Adds disk / directory labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on Lunar PR #2451, which fixes a critical issue required for the File Field Attribute to function correctly. This PR resolves the issue discussed here: Lunar Discussion #2452.