Open
Conversation
There was a problem hiding this comment.
4 issues found across 14 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docker/Dockerfile_gstreamer_webrtc_test">
<violation number="1" location="docker/Dockerfile_gstreamer_webrtc_test:45">
P2: Unverified `curl | sh` installer execution introduces supply-chain risk during image build.</violation>
</file>
<file name="tests/CMakeLists.txt">
<violation number="1" location="tests/CMakeLists.txt:24">
P2: `Python3_EXECUTABLE` is used without declaring Python via `find_package(Python3)`, making configuration dependent on external cache/toolchain state and potentially failing standalone builds.</violation>
<violation number="2" location="tests/CMakeLists.txt:304">
P2: Optional target `lvgl_thorvg` is linked unconditionally, which can break builds when that target is not defined.</violation>
</file>
<file name="tests/scripts/run_gstreamer_webrtc_test.sh">
<violation number="1" location="tests/scripts/run_gstreamer_webrtc_test.sh:66">
P2: Background signaller/sender startup is not validated, so early process failure can be missed and cause misleading test failures later.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Author
There was a problem hiding this comment.
This file is probably not needed as we can add those packages to the existing docker image
Dockerfile_DEBIAN
Author
There was a problem hiding this comment.
The ref_imgs are actually in the other directory. This needs to be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR to propose gstreamer testing in a docker/ubuntu environment, actually it runs on any other linux computer with or without docker. And this is why I suggest to test the gstreamer (i just added webrtc for now) in the lv_port_linux.
Here the test run:
https://github.com/lvgl/lv_port_linux/actions/runs/23644003471/job/68871497980?pr=130
I also run a negative test without the ref image versioned.
For any other detail please read readme files.