Skip to content

Webrtc test#130

Open
leonardosalvatore wants to merge 4 commits intolvgl:masterfrom
leonardosalvatore:webrtc_test
Open

Webrtc test#130
leonardosalvatore wants to merge 4 commits intolvgl:masterfrom
leonardosalvatore:webrtc_test

Conversation

@leonardosalvatore
Copy link
Copy Markdown

@leonardosalvatore leonardosalvatore commented Mar 27, 2026

This PR to propose gstreamer testing in a docker/ubuntu environment, actually it runs on any other linux computer with or without docker. And this is why I suggest to test the gstreamer (i just added webrtc for now) in the lv_port_linux.

Here the test run:
https://github.com/lvgl/lv_port_linux/actions/runs/23644003471/job/68871497980?pr=130

I also run a negative test without the ref image versioned.

For any other detail please read readme files.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 issues found across 14 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docker/Dockerfile_gstreamer_webrtc_test">

<violation number="1" location="docker/Dockerfile_gstreamer_webrtc_test:45">
P2: Unverified `curl | sh` installer execution introduces supply-chain risk during image build.</violation>
</file>

<file name="tests/CMakeLists.txt">

<violation number="1" location="tests/CMakeLists.txt:24">
P2: `Python3_EXECUTABLE` is used without declaring Python via `find_package(Python3)`, making configuration dependent on external cache/toolchain state and potentially failing standalone builds.</violation>

<violation number="2" location="tests/CMakeLists.txt:304">
P2: Optional target `lvgl_thorvg` is linked unconditionally, which can break builds when that target is not defined.</violation>
</file>

<file name="tests/scripts/run_gstreamer_webrtc_test.sh">

<violation number="1" location="tests/scripts/run_gstreamer_webrtc_test.sh:66">
P2: Background signaller/sender startup is not validated, so early process failure can be missed and cause misleading test failures later.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is probably not needed as we can add those packages to the existing docker image
Dockerfile_DEBIAN

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ref_imgs are actually in the other directory. This needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant