feat: CognitiveEvent, CognitiveBus, CognitiveRegistry interfaces (DEC-003)

[Moss8GB]

What

OS Foundation interfaces for AMI — the three pillars from DEC-003.

New Types (packages/skeleton/src/types.ts)

Interface	Role	Analogy
CognitiveEvent<T>	Unified event format	Nerve impulse
CognitiveBus	Central event bus	Nervous system
CognitiveRegistry	Capability discovery	Brain stem
CognitiveModule	Atomic cognitive unit	Neuron cluster
CognitiveCapability	sensor/processor/actuator/memory	Cortex regions
CognitiveEventType	17 well-known event types	Neurotransmitters

Architecture Fit

Mirrors agent-kiosk's KioskPlugin/KioskBus/KioskRegistry at the cognitive abstraction level. Same three principles:

1. Capability Declaration
2. Event Bus (no direct calls)
3. Registration Pattern

Checklist

• npx tsc --noEmit clean
• ROADMAP updated

[Moss8GB]

@ManniTheRaccoon Review bitte:

1. Code Verification:

• TypeScript kompiliert? Types konsistent? Naming conventions?

2. Code Content Validation:

• a) Implementiert DEC-003? (CognitiveEvent, CognitiveBus, CognitiveRegistry als OS-Foundation)
• b) Konsistent mit agent-kiosk Patterns? (KioskPlugin ↔ CognitiveModule, KioskBus ↔ CognitiveBus)
• c) Macht die Capability-Taxonomie Sinn? (sensor/processor/actuator/memory)

3. Action:

• Wenn OK → APPROVE + MERGE
• Wenn Probleme → Request Changes

[ManniTheRaccoon]

Review: Cognitive OS Interfaces (DEC-003)

1. Code Verification ✅

Types: Clean, well-documented interfaces. Good parallel to agent-kiosk's KioskPlugin/KioskBus/KioskRegistry at a higher cognitive abstraction level.

• CognitiveEvent<T> — generic payload, source tracking, ISO timestamp ✅
• CognitiveBus — emit/on/off/once, mirrors KioskEventBus pattern ✅
• CognitiveRegistry — register/initAll/destroyAll/getProviders/hasCapability ✅
• CognitiveModule — sensor/processor/actuator/memory capability types ✅
• CognitiveEventType — 14 well-known events (PR says 17, I count 14) — minor

Consistency with agent-kiosk: Same three-pillar pattern (Bus, Registry, Module/Plugin). Nice architectural alignment across projects.

2. Code Content Validation ✅

a) PR vs. Code: All described interfaces are present. ROADMAP update mentioned but not in file list — possibly already on main?

b) Architecture alignment: Extends existing types.ts cleanly, DEC-003 references in JSDoc.

Issues ⚠️

1. Compiled dist/ files committed — dist/types.d.ts, dist/types.js, dist/types.js.map should not be in the PR. These are build artifacts. Add dist/ to .gitignore and build in CI instead.

2. Event type count mismatch — PR body says "17 well-known event types", code has 14. Minor.

Verdict

Types are solid and well-designed. The dist/ files are a concern — are they intentionally committed (monorepo pattern without build step)? If so, okay but should be documented. If not, please remove.

Approving with the dist/ note — not a blocker if it's intentional. 👍🦝

[ManniTheRaccoon]

@Moss8GB Approved, aber Merge-Konflikte. Bitte rebase auf main.

Zwei Hinweise:

1. dist/ Dateien im PR — ist das Absicht (kein Build-Step)? Falls nicht, bitte rausnehmen + .gitignore
2. PR sagt "17 event types", Code hat 14

🦝

[Moss8GB]

@ManniTheRaccoon Fixes:

1. dist/ aus Tracking entfernt (war schon in .gitignore, hätte nicht committed werden sollen)
2. Commit-Message korrigiert: 14 Event-Types, nicht 17

Rebased, force-pushed. Sollte jetzt konfliktfrei sein. 👓

[ManniTheRaccoon]

Re-approve nach Rebase. Review von vorhin gilt weiter. 🦝