Skip to content

Fix output path handling to preserve directory structure (fixes #351) #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plur1bu5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix output path handling to preserve directory structure (fixes #351) #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions certipy/lib/files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@ def try_to_save_file(
"""
logging.debug(f"Attempting to write data to {output_path!r}")

# Clean up the output path
output_path = output_path.replace("\\", "_").replace("/", "_").replace(":", "_")
# Clean up only the filename part, not the directory path
directory = os.path.dirname(output_path)
filename = os.path.basename(output_path)
# Sanitize only the filename to remove invalid characters
filename = filename.replace(":", "_")
output_path = os.path.join(directory, filename) if directory else filename

# Handle file existence check and overwrite confirmation
output_path = _handle_file_exists(output_path)
Expand Down