-
Notifications
You must be signed in to change notification settings - Fork 119
refactor: align Lynx terminology with official specification #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Huxpro
wants to merge
9
commits into
main
Choose a base branch
from
Huxpro/fetch-lynx-docs-v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+326
−102
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a4724f2
refactor: align Lynx terminology with official specification
Huxpro 01aac26
refactor: flip alias direction so new names hold the definitions
Huxpro 6f0b0a2
fix: add explicit type annotation for isolatedDeclarations and revert…
Huxpro be16fc5
fix: sort imports and update API report files
Huxpro eb726a5
fix: add changeset and fix defineDCE test for rspeedy compatibility
Huxpro 2f7528a
chore: update pnpm-lock.yaml after rebase onto main
Huxpro ccef93e
chore: dedupe pnpm lockfile
Huxpro 97e5db3
Merge branch 'main' into Huxpro/fetch-lynx-docs-v1
Huxpro 21774ee
Update packages/web-platform/web-core-wasm/ts/constants.ts
Huxpro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "@lynx-js/web-constants": patch | ||
| "@lynx-js/web-core": patch | ||
| "@lynx-js/react-webpack-plugin": patch | ||
| "@lynx-js/template-webpack-plugin": patch | ||
| "@lynx-js/react-rsbuild-plugin": patch | ||
| --- | ||
|
|
||
| Align codebase terminology with the official Lynx specification. Add new preferred type aliases (`LynxBundle`, `BundleLoader`, `DecodedBundle`, `BundleSectionLabel`, `BundleHooks`, `LynxBundlePlugin`, `LynxBundlePluginOptions`) and deprecate legacy names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 10 additions & 2 deletions
12
packages/web-platform/web-constants/src/types/TemplateLoader.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| import type { LynxTemplate } from './LynxModule.js'; | ||
| import type { LynxBundle } from './LynxModule.js'; | ||
|
|
||
| export type TemplateLoader = (url: string) => Promise<LynxTemplate>; | ||
| /** | ||
| * Loads a Lynx Bundle from the given URL. | ||
| */ | ||
| export type BundleLoader = (url: string) => Promise<LynxBundle>; | ||
|
|
||
| /** | ||
| * @deprecated Use {@link BundleLoader} instead. | ||
| */ | ||
| export type TemplateLoader = BundleLoader; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 108
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 1637
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 532
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 48
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 592
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 48
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 1257
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 257
🏁 Script executed:
Repository: lynx-family/lynx-stack
Length of output: 271
Add JSDoc with
@publicrelease tag to LynxBundlePlugin interface.The
LynxBundlePlugininterface exported frompackages/rspeedy/plugin-react/src/index.tsis missing proper JSDoc documentation with a release tag. API Extractor correctly flagged this and defaulted to@public (undocumented). Other exported types in the same file likePluginReactLynxOptionsinclude proper JSDoc with the@publictag—LynxBundlePluginshould follow the same pattern.🤖 Prompt for AI Agents