Skip to content

fix(devtool-mcp-server): send Page.enable before Runtime.enable#2302

Merged
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0305/devtool-mcp-server-1
Mar 5, 2026
Merged

fix(devtool-mcp-server): send Page.enable before Runtime.enable#2302
colinaaa merged 1 commit intolynx-family:mainfrom
colinaaa:colin/0305/devtool-mcp-server-1

Conversation

@colinaaa
Copy link
Collaborator

@colinaaa colinaaa commented Mar 5, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Chrome DevTools Protocol initialization sequence to ensure proper domain enablement order.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 063e517a-dfec-4eae-90d6-4c6fc517c9a8

📥 Commits

Reviewing files that changed from the base of the PR and between 8517e2c and 6847091.

📒 Files selected for processing (2)
  • .changeset/fuzzy-mangos-speak.md
  • packages/mcp-servers/devtool-mcp-server/src/tools/Runtime/ListConsole.ts

📝 Walkthrough

Walkthrough

A changeset metadata file is introduced, and a CDP (Chrome DevTools Protocol) stream message is added to the ListConsole runtime configuration to enable the Page domain before the Runtime domain.

Changes

Cohort / File(s) Summary
Changeset Management
.changeset/fuzzy-mangos-speak.md
New changeset entry with minimal YAML frontmatter structure.
Runtime Configuration
packages/mcp-servers/devtool-mcp-server/src/tools/Runtime/ListConsole.ts
Adds a new CDP stream message with sessionId and Page.enable method preceding the existing Runtime.enable call, establishing proper domain initialization order.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A Page before Runtime must dance,
The protocol takes its rightful stance,
First enable the domain so free,
Then Runtime flows with harmony! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: sending Page.enable before Runtime.enable in devtool-mcp-server, which matches the code modification shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

🦋 Changeset detected

Latest commit: 6847091

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...evtool-mcp-server/src/tools/Runtime/ListConsole.ts 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 5, 2026

Merging this PR will degrade performance by 6.11%

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 69 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
transform 1000 view elements 47.1 ms 40.2 ms +17.01%
basic-performance-nest-level-100 7.5 ms 6.8 ms +11.04%
basic-performance-scroll-view-100 8.7 ms 9.3 ms -6.11%

Comparing colinaaa:colin/0305/devtool-mcp-server-1 (6847091) with main (8517e2c)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link

relativeci bot commented Mar 5, 2026

Web Explorer

#7955 Bundle Size — 383.53KiB (0%).

6847091(current) vs 8517e2c main#7953(baseline)

Bundle metrics  no changes
                 Current
#7955
     Baseline
#7953
No change  Initial JS 154.63KiB 154.63KiB
No change  Initial CSS 35.1KiB 35.1KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
No change  Modules 239 239
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.99% 2.99%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#7955
     Baseline
#7953
No change  JS 252.58KiB 252.58KiB
No change  Other 95.85KiB 95.85KiB
No change  CSS 35.1KiB 35.1KiB

Bundle analysis reportBranch colinaaa:colin/0305/devtool-mcp-...Project dashboard


Generated by RelativeCIDocumentationReport issue

@colinaaa colinaaa marked this pull request as ready for review March 5, 2026 03:20
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6847091c3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@colinaaa colinaaa merged commit e7d94be into lynx-family:main Mar 5, 2026
46 of 48 checks passed
@colinaaa colinaaa deleted the colin/0305/devtool-mcp-server-1 branch March 5, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants