Skip to content

Fix the exits with status 1 with disabled cops #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vassalloandrea wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −5
Open

Fix the exits with status 1 with disabled cops #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions lib/rubocop/git/runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def run(options)

display_violations($stdout)

exit(1) if violations.any?
exit(1) if violations_with_valid_offences.any?
end

private
Expand All @@ -21,11 +21,23 @@ def violations
@violations ||= style_checker.violations
end

def violations_with_valid_offences
@violations_with_valid_offences ||= begin
violations.map do |violation|
offenses = violation.offenses
offenses = offenses.reject(&:disabled?) if offenses.first.respond_to?(:disabled?)
offenses.any? ? violation : nil
end.compact
end
end

def style_checker
StyleChecker.new(pull_request.pull_request_files,
@options.rubocop,
@options.config_file,
pull_request.config)
StyleChecker.new(
pull_request.pull_request_files,
@options.rubocop,
@options.config_file,
pull_request.config
)
end

def pull_request
Expand Down