Skip to content

Modernize library to PHP 8.4#41

Merged
jdrieghe merged 4 commits intomainfrom
modernize-php84
Mar 20, 2026
Merged

Modernize library to PHP 8.4#41
jdrieghe merged 4 commits intomainfrom
modernize-php84

Conversation

@jdrieghe
Copy link
Copy Markdown
Member

What changed

Added

  • PHP CS Fixer for code style enforcement (.php-cs-fixer.dist.php)
  • CI job for code style checks

Changed

  • Minimum PHP version raised to 8.4
  • Namespace changed from Madewithlove\ to Madewithlove\HtaccessApiClient\
  • HtaccessResult, ResultLine, and ShareResult are now readonly classes
  • ServerVariables and HtaccessException are now final
  • API requests now include an Accept: application/json header, fixing error responses that previously returned a redirect
  • Error response handling updated to match the current API format
  • PHPUnit upgraded from 9 to 13, PHPStan from 1 to 2, Infection from 0.26 to 0.32
  • Replaced deprecated Guzzle adapter packages with native Guzzle 7 PSR-18 support
  • CI updated to use modern GitHub Actions versions and a dedicated code style job

Removed

  • ServerVariable class — it was already deprecated; use plain strings instead

@jdrieghe jdrieghe self-assigned this Mar 19, 2026
@jdrieghe jdrieghe requested a review from WouterSioen March 19, 2026 20:07
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5719411) to head (0fa4f10).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #41   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        27        30    +3     
===========================================
  Files              6         6           
  Lines            108       113    +5     
===========================================
+ Hits             108       113    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@WouterSioen WouterSioen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jdrieghe jdrieghe merged commit fd1cd75 into main Mar 20, 2026
11 checks passed
@jdrieghe jdrieghe deleted the modernize-php84 branch March 20, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants