Ml/siglent rework2#308
Open
mileslucas wants to merge 6 commits into
Open
Conversation
d1783fd to
8d11047
Compare
Contributor
Author
|
This has critical bugs in the
Now, I suspect this might have to do with the way the indi properties are set up in modwfs. Rather than having two separate properties for each fxngen parameter (one listening for the current value, and one used for sending the target value), but I haven't confirmed that. If so, the correct approach would a bit of a more significant rewrite of modwfs, rewriting the entire indi property logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #290 without git issues.