Update to Dark Script#368
Open
edenacadia wants to merge 5 commits into
Open
Conversation
…rs. Allow request for previous night of data
Member
|
Looking good! There are some |
Contributor
Author
|
@joseph-long Cleaned up print statements and finished testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to
collect_camera_configs_for_darksandshot_in_the_darkpython scripts for end-of-night dark taking.Summary
Initial work done to make script compatible with new datetime file formats.
This work written in part by Codex 5.3 in response to the prompt: "In the shot_in_the_dark script, we need a way to cleanly exit on a keyboard interrupt. When interrupted, the script should print out a "exiting" statement, release control of the cameras and shutters, and save a json file with the darks remaining to do".
collect_camera_configs_for_darksto support richer date/time filtering (--night,--date-start/--date-end, and--last-night) and include observation directory metadata in output for better provenance.shot_in_the_dark: printexiting, stop worker threads cooperatively, persist remaining dark configurations to*_remaining.json, and always run cleanup to return observing/streamwriter/camera state to safe defaults (including EM gain reset).Test plan
python -m py_compile scripts/shot_in_the_darkcollect_camera_configs_for_darkswith:--night YYYY-MM-DD--date-start YYYY-MM-DD_HHMMSS --date-end YYYY-MM-DD_HHMMSS--last-nightshot_in_the_darkagainst a small config and press Ctrl+C mid-run; verify:exitingis printed<input>_remaining.jsonis written with unfinished configs