ogTracker: add rolling PCA tracking app, cbuff stream compatible #373
Draft
edenacadia wants to merge 18 commits into
Draft
ogTracker: add rolling PCA tracking app, cbuff stream compatible #373edenacadia wants to merge 18 commits into
edenacadia wants to merge 18 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work was partially done by GPT-5.3-Codex in response to the prompt: "Implement ogTracker patterned after strehlEstimator to read aol1_imWFS2, load PCA calibrations based on tweeterSpeck sparkle parameters, compute rolling PCA RMS metrics normalized by ref_rms, and harden runtime behavior/logging."
Additional prompts include: "Move rolling PCA statistics in ogTracker from the internal Eigen ring (m_ringFrames) to a modalPSDs-style pointer circular buffer that stores curr_src frame pointers from aol1_imWFS2_cbuff."
Summary
ogTrackerMagAO-X app and integrate it into the top-level build.aol1_imWFS2_cbuffstream, including calibration lookup from livetweeterSpeckparameters, normalized OG metrics, running averages, and telemetry/INDI publication.ogTracker, and update test Doxygen grouping so the application tests follow current repository documentation rules.Affected Files
Makefileapps/ogTracker/Makefileapps/ogTracker/ogTracker.cppapps/ogTracker/ogTracker.hppapps/ogTracker/tests/ogTracker_test.cpptests/groups.doxTest Plan
ogTrackerin the MagAO-X environment.ogTrackerunit test target that includesapps/ogTracker/tests/ogTracker_test.cpp.aol1_imWFS2_cbuffstream, verifycalib_*,pca_og,pca_og_avg, andog_summaryupdate as expected.tweeterSpeckseparation, angle, amplitude, frequency, or modulation state changes.Follow-up / Edge Cases
og_summarydefinition and publication semantics match downstream expectations.