Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Kubernetes topologySpreadConstraints to enable the scheduler and webServer deployments to better distribute pods across failure domains.
- Added empty topologySpreadConstraints arrays with commented examples in values.yaml for both scheduler and webServer.
- Updated scheduler.yaml and deployment.yaml templates to render topologySpreadConstraints with conditional logic to include label selectors.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/mageai/values.yaml | Adds topologySpreadConstraints arrays with sample commented configurations. |
| charts/mageai/templates/scheduler.yaml | Implements topologySpreadConstraints rendering with conditional labelSelector inclusion for the scheduler. |
| charts/mageai/templates/deployment.yaml | Implements topologySpreadConstraints rendering with conditional labelSelector inclusion for the webServer. |
Comments suppressed due to low confidence (1)
charts/mageai/templates/scheduler.yaml:120
- [nitpick] The helper function names differ between templates ('mageai.schedulerSelectorLabels' in scheduler.yaml versus 'mageai.selectorLabels' in deployment.yaml). If these perform similar tasks, consider standardizing their names for consistency.
{{- include "mageai.schedulerSelectorLabels" $ | nindent 14 }}
49f09aa to
70f7c82
Compare
Signed-off-by: fe80 <steffyfort@gmail.com>
70f7c82 to
5ec1982
Compare
|
Up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This feature add topologySpreadConstraints
support
Tests
cc: