-
Notifications
You must be signed in to change notification settings - Fork 15
Bundle mage-os/module-automatic-translation #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I reviewed the meta-robots-tag module. Please handle issues 1 and 2 if possible. I'll review the translation module later this week. |
I reviewed the translation module as well. Functionally this one looks good. There are some quality issues that should be improved, and especially encrypting the API keys. |
To this actual PR: Please
Handled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See last comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need issues 13, 16, 19, 22, 23, 24 addressed at minimum before we could bundle it
resource/composer-templates/mage-os/product-community-edition/dependencies-template.json
Show resolved
Hide resolved
Mostly done -- one to merge, one still open, and a release of it all. |
Merging. |
I propose adding mage-os/module-automatic-translation as a bundled module. https://github.com/mage-os/module-automatic-translation
Implications
Risks
Benefits
PR
This PR results in the module being added as a pinned require of mage-os/product-community-edition like:
which composer will then require via Packagist, like any other third party package. The latest published version will be pinned at the time of each release.