Skip to content

Update ESLint configuration #32343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update ESLint configuration #32343

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
107f4b2
Update ESLint configuration
fredden Mar 2, 2021
52e3a4d
Merge branch '2.4-develop' into eslint
fredden Mar 18, 2021
8f52cde
Merge branch '2.4-develop' into eslint
fredden Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 103 additions & 1 deletion dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/.eslintrc-magento
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,32 @@
"env": {
"amd": true,
"browser": true,
"es6": true,
"jasmine": true,
"jquery": true,
"prototypejs": true,
"node": true
},
"rules": {
"array-bracket-spacing": [2, "never"],
"arrow-spacing": [2, {"after": true, "before": true}],
"block-spacing": [2, "always"],
"brace-style": [2, "1tbs", {"allowSingleLine": true}],
"comma-spacing": [2, {"after": true, "before": false}],
"comma-style": [2, "last"],
"constructor-super": 2,
"curly": [2, "multi-line"],
"dot-location": [2, "property"],
"dot-notation": [2, {"allowKeywords": true}],
"eol-last": 2,
"eqeqeq": [2, "smart"],
"func-call-spacing": [2, "never"],
"generator-star-spacing": [2, {"after": true, "before": true}],
"guard-for-in": 2,
"indent": [2, 4],
"key-spacing": [2, {"afterColon": true, "beforeColon": false}],
"keyword-spacing": [2, {"after": true, "before": true}],
"linebreak-style": [2, "unix"],
"lines-around-comment": [
2,
{
Expand All @@ -18,18 +36,36 @@
"allowObjectStart": true
}
],
"lines-between-class-members": [2, "always", {"exceptAfterSingleLine": true}],
"max-depth": [2, 2],
"max-len": [2, 120, 4],
"max-nested-callbacks": [2, 3],
"multiline-ternary": [2, "always-multiline"],
"new-cap": [2, {"capIsNew": false, "newIsCap": true, "properties": true}],
"new-parens": 2,
"newline-after-var": 2,
"no-alert": 2,
"no-array-constructor": 2,
"no-caller": 2,
"no-case-declarations": 2,
"no-catch-shadow": 2,
"no-class-assign": 2,
"no-compare-neg-zero": 2,
"no-cond-assign": 2,
"no-console": 2,
"no-const-assign": 2,
"no-constant-condition": 2,
"no-control-regex": 2,
"no-debugger": 2,
"no-delete-var": 2,
"no-dupe-args": 2,
"no-dupe-class-members": 2,
"no-dupe-keys": 2,
"no-duplicate-case": 2,
"no-else-return": 2,
"no-empty-character-class": 2,
"no-empty-pattern": 2,
"no-empty": [2, {"allowEmptyCatch": true}],
"no-eval": 2,
"no-ex-assign": 2,
"no-extend-native": 2,
Expand All @@ -40,25 +76,57 @@
"no-fallthrough": 2,
"no-floating-decimal": 2,
"no-func-assign": 2,
"no-global-assign": 2,
"no-implied-eval": 2,
"no-inner-declarations": 2,
"no-invalid-regexp": 2,
"no-irregular-whitespace": 2,
"no-iterator": 2,
"no-labels": [2, {"allowLoop": false, "allowSwitch": false}],
"no-lone-blocks": 2,
"no-lonely-if": 2,
"no-loop-func": 2,
"no-mixed-operators": [2, {"allowSamePrecedence": true, "groups": [["==", "!=", "===", "!==", ">", ">=", "<", "<="], ["&&", "||"], ["in", "instanceof"]]}],
"no-mixed-spaces-and-tabs": 2,
"no-multi-spaces": 2,
"no-multi-str": 2,
"no-multiple-empty-lines": [2, {"max": 1, "maxEOF": 0}],
"no-native-reassign": 2,
"no-negated-in-lhs": 2,
"no-new-func": 2,
"no-new-object": 2,
"no-new-symbol": 2,
"no-new-wrappers": 2,
"no-new": 2,
"no-obj-calls": 2,
"no-octal-escape": 2,
"no-octal": 2,
"no-proto": 2,
"no-prototype-builtins": 2,
"no-redeclare": 2,
"no-regex-spaces": 2,
"no-return-assign": 2,
"no-self-assign": [2, {"props": true}],
"no-self-compare": 2,
"no-sequences": 2,
"no-shadow": 2,
"no-shadow-restricted-names": 2,
"no-sparse-arrays": 2,
"no-tabs": 2,
"no-template-curly-in-string": 2,
"no-this-before-super": 2,
"no-throw-literal": 2,
"no-trailing-spaces": 2,
"no-undef": 2,
"no-undef-init": 2,
"no-unexpected-multiline": 2,
"no-unmodified-loop-condition": 2,
"no-unneeded-ternary": [2, {"defaultAssignment": false}],
"no-unreachable": 2,
"no-unsafe-finally": 2,
"no-unsafe-negation": 2,
"no-unused-expressions": [2, {"allowShortCircuit": true, "allowTaggedTemplates": true, "allowTernary": true}],
"no-unused-labels": 2,
"no-unused-vars": [
2,
{
Expand All @@ -68,14 +136,48 @@
}
],
"no-use-before-define": 2,
"no-useless-call": 2,
"no-useless-computed-key": 2,
"no-useless-constructor": 2,
"no-useless-escape": 2,
"no-useless-rename": 2,
"no-useless-return": 2,
"no-var": 2,
"no-void": 2,
"no-whitespace-before-property": 2,
"no-with": 2,
Copy link
Contributor

@mrtuvn mrtuvn Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-var may cause some errors since i see lot of js code still use var ?

Copy link
Member Author

@fredden fredden Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://eslint.org/docs/rules/no-var

The idea here is to configure ESLint to encourage use of modern JavaScript. Yes, var still works but let and const are preferred.

"object-curly-newline": [2, {"consistent": true, "multiline": true}],
"object-curly-spacing": [2, "always"],
"object-property-newline": [2, {"allowMultiplePropertiesPerLine": true}],
"one-var": [2, {"initialized": "never"}],
"operator-assignment": [2, "always"],
"operator-linebreak": [2, "after", {"overrides": {":": "before", "?": "before", "|>": "before"}}],
"padded-blocks": [2, {"blocks": "never", "classes": "never", "switches": "never"}],
"prefer-const": [2, {"destructuring": "all"}],
"prefer-promise-reject-errors": 2,
"quote-props": [2, "as-needed"],
"quotes": [2, "single", {"avoidEscape": true}],
"radix": 2,
"require-yield": 2,
"rest-spread-spacing": [2, "never"],
"semi": [2, "always"],
"semi-spacing": 2,
"space-before-blocks": [2, "always"],
"space-before-function-paren": [2, "always"],
"space-in-parens": [2, "never"],
"space-infix-ops": 2,
"space-unary-ops": [2, {"nonwords": false, "words": true}],
"spaced-comment": [2, "always", {"block": {"balanced": true, "exceptions": ["*"], "markers": ["*package", "!", ",", ":", "::", "flow-include"]}, "line": {"markers": ["*package", "!", "/", ",", "="]}}],
"strict": ["error", "function"],
"symbol-description": 2,
"template-curly-spacing": [2, "never"],
"template-tag-spacing": [2, "never"],
"unicode-bom": [2, "never"],
"use-isnan": 2,
"valid-typeof": 2,
"vars-on-top": 2
"vars-on-top": 2,
"wrap-iife": [2, "any", {"functionPrototypeMethods": true}],
"yield-star-spacing": [2, "both"],
"yoda": [2, "never"]
}
}