Skip to content

Use :: syntax for enum values #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Use :: syntax for enum values #1

merged 1 commit into from
Jun 5, 2025

Conversation

benjie
Copy link

@benjie benjie commented Jun 5, 2025 •
edited
Loading

This was referenced Jun 5, 2025
Merged
Merged
Merged
martinbonnin
martinbonnin approved these changes Jun 5, 2025
View reviewed changes
Copy link

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this distinction. Enum members are indeed quite different!

@magicmark magicmark merged commit ff1ccb4 into magicmark:schema_coordinates_spec_edit Jun 5, 2025
@magicmark
Copy link
Owner

makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@martinbonnin martinbonnin martinbonnin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjie @magicmark @martinbonnin