Fix section screenshot URLs to use Rails asset_host when available #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update FetchSectionScreenshotPath to check Rails.application.config.asset_host - Supports both string and proc asset_host configurations - Fixes 500 errors for section preview images when static file serving is disabled - Only affects section screenshot/preview images in the editor
|
implemented here -> #187 Thanks @AlanMcCann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 500 errors for section preview images in the Maglev editor when static file serving is disabled in production environments.
Problem
When Rails applications have static file serving disabled (common in production with CDN usage), section screenshot URLs in the Maglev editor fail with 500 errors because they try to serve static assets directly from the application server.
Solution
FetchSectionScreenshotPathservice to check for Railsasset_hostconfigurationasset_hostconfigurations with proper evaluationasset_hostis configuredTesting
This change ensures section preview images work correctly in production environments using CDNs while maintaining backward compatibility.