[codex] avoid false drift reports in setup check with OMX coexistence#101
Draft
majiayu000 wants to merge 1 commit intomainfrom
Draft
[codex] avoid false drift reports in setup check with OMX coexistence#101majiayu000 wants to merge 1 commit intomainfrom
majiayu000 wants to merge 1 commit intomainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hook Latency (P95)
Details
| Benchmark suite | Current: a3999a7 | Previous: 075c3ed | Ratio |
|---|---|---|---|
pre-edit-guard (P95) |
144 ms |
188 ms |
0.77 |
pre-write-guard (P95) |
166 ms |
213 ms |
0.78 |
pre-bash-guard (P95) |
205 ms |
255 ms |
0.80 |
post-edit-guard (100) (P95) |
240 ms |
298 ms |
0.81 |
post-write-guard (100) (P95) |
160 ms |
208 ms |
0.77 |
post-edit-guard (5000) (P95) |
251 ms |
314 ms |
0.80 |
post-write-guard (5000) (P95) |
163 ms |
209 ms |
0.78 |
stop-guard (5000) (P95) |
94 ms |
132 ms |
0.71 |
learn-evaluator (5000) (P95) |
94 ms |
132 ms |
0.71 |
This comment was automatically generated by workflow using github-action-benchmark.
…nfig VibeGuard was treating shared mutable config files as immutable install artifacts, so setup.sh --check reported checksum drift even when the required hooks and flags were still present. This changes install-state drift detection to skip whole-file checksum enforcement for the semantically validated merge targets, tightens the Claude-side warning text so missing Claude hooks are called out explicitly, and adds a setup regression covering benign coexistence edits after installation. Constraint: ~/.claude/settings.json, ~/.codex/hooks.json, and ~/.codex/config.toml are shared merge targets that other toolchains continue to edit after setup Rejected: Keep whole-file checksum drift on shared config files | produces false positives under normal OMX/Codex coexistence Confidence: high Scope-risk: narrow Reversibility: clean Directive: Preserve semantic validation for shared config files; do not reintroduce whole-file checksum drift checks unless config ownership becomes exclusive Tested: bash tests/test_setup.sh Not-tested: GitHub Actions run on this branch; non-OMX external toolchains beyond the setup regression fixture
majiayu000
force-pushed
the
codex/fix-setup-check-coexistence
branch
from
330995d to
a3999a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a noisy
setup.sh --checkfalse positive when VibeGuard coexists with OMX/Codex-managed config files.Specifically it:
Root Cause
VibeGuard was recording whole-file checksums for:
~/.claude/settings.json~/.codex/hooks.json~/.codex/config.tomlThose files are merge/upsert targets that other toolchains continue to edit after setup. As long as the required VibeGuard entries were still present, the whole-file checksum check was too strict and turned normal coexistence into spurious drift.
Impact
setup.sh --checkno longer reports checksum mismatch for benign OMX/Codex coexistence editsValidation
bash tests/test_setup.shNotes
This PR intentionally keeps the change narrow: