Skip to content

Improved install routine #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improved install routine #11

wants to merge 5 commits into from

Conversation

the-phinet
Copy link
Contributor

This commit set contains a number of fixes and changes. I can split them into multiple pull requests if you'd like

Fixes:

  • The deletion temp folders 'deps' and 'aseprite' could result in loss of user data. This have been fixed by using a unique temp folder
  • The script cleans up after itself, even if it exits early
  • Any commands that touch the file system are checked for success, and will exit early if they fail. This addresses Error handling #4

Changes:

  • Moved the output folder to the location specified by XDG
  • Added aseprite to the user's path for command line execution
  • Script now automatically installs the official desktop file

Changed install folder to follow xdg specification
Changed temp and working folders in order to avoid user data deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant