Skip to content

fix for laravel 5.4 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for laravel 5.4 #25

wants to merge 1 commit into from

Conversation

rohstar
Copy link

@rohstar rohstar commented Jan 15, 2018

The share method has been removed from the container. This was a legacy method that has not been documented in several years. so we should begin using the singleton method instead

qmcree
qmcree reviewed Jan 17, 2018
View reviewed changes
src/ServiceProviderLaravel5.php
$this->mergeConfigFrom(__DIR__.'/config/config.php', 'slack');

$this->app['maknz.slack'] = $this->app->share(function ($app) {
$this->app['maknz.slack'] = $this->app->singleton('maknz.slack', function () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The singleton method doesn't return anything, so it shouldn't be assigned to that Container key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@qmcree qmcree qmcree left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohstar @qmcree