Fix branch lookup for merge requests with slashes in branch names #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used `repo.Branch()` which fails to resolve branch names containing slashes (e.g., "feature/ticket-12345"). This caused valid open merge requests to be skipped with "branch not found" errors. Changed to use `repo.Reference()` with `plumbing.NewBranchReferenceName()` which properly handles branch names with slashes by constructing the full ref path (refs/heads/feature/ticket-12345). Also added debug logging to track branch lookup attempts and improved error reporting to aid future troubleshooting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used
repo.Branch()which fails to resolve branch names containing slashes (e.g., "feature/ticket-12345"). This caused valid open merge requests to be skipped with "branch not found" errors.Changed to use
repo.Reference()withplumbing.NewBranchReferenceName()which properly handles branch names with slashes by constructing the full ref path (refs/heads/feature/ticket-12345).Also added debug logging to track branch lookup attempts and improved error reporting to aid future troubleshooting.