Open
Conversation
Grabbing the contents by ID instead of by class seems to stop the large gap that we were seeing where the contents used to be in the sphinx source.
cailafinn
changed the title
|
Can't this be tested by building dev docs and opening in the browser? |
Author
|
Since this is in a different repo I don't think it would pick this up unless it was merged into main/on anaconda? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grabbing the contents by ID instead of by class seems to stop the large gap that we were seeing where the contents used to be in the sphinx source.
The
visibilitytag is also no-longer needed as the entire element including its box is no longer displayed.I think the source of the bug is that the
pydata-sphinx-themealready makes changes to the contents class and the style in here isn't overriding them. Which is maybe a larger-scale config issue.To test
style.cssuntil it looked right. If there's a better way to test this out I'd be interested to hear it.