Skip to content

Improved Theme selector that outlines the current theme#57

Open
hansaskov wants to merge 34 commits intomanuelernestog:mainfrom
hansaskov:demo
Open

Improved Theme selector that outlines the current theme#57
hansaskov wants to merge 34 commits intomanuelernestog:mainfrom
hansaskov:demo

Conversation

@hansaskov
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for astrofy-template ready!

Name Link
🔨 Latest commit 14a4c72
🔍 Latest deploy log https://app.netlify.com/sites/astrofy-template/deploys/65a7eca93bb11000083d89e2
😎 Deploy Preview https://deploy-preview-57--astrofy-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for astro-modern-personal-website ready!

Name Link
🔨 Latest commit 14a4c72
🔍 Latest deploy log https://app.netlify.com/sites/astro-modern-personal-website/deploys/65a7eca9ce32a40008ecdcff
😎 Deploy Preview https://deploy-preview-57--astro-modern-personal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hansaskov
Copy link
Author

hansaskov commented Jan 17, 2024

I have used your project for my personal use cases and spend some time to improve upon the theme selector. The changes are as follows:

  • The current theme is now shown with an outline

  • Added a fill to the theme svg. This is done because there would be cases where text could be seen through the icon at medium screen sizes

  • Cleaned up code by mapping over all the themes instead of hard coding each one

@hansaskov
Copy link
Author

@manuelernestog What do you think?

aaronlippold added a commit to aaronlippold/astrofy that referenced this pull request Jan 11, 2026
- Add ThemeSelector component with all 33 DaisyUI themes
- Persist theme selection in localStorage
- Default to 'lofi' theme (current site theme)
- Add to Header navbar-end for easy access
- Based on PR manuelernestog#57 from upstream astrofy repo

Authored by: Aaron Lippold <lippold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants