π‘οΈ Sentinel: [HIGH] Fix SQL injection in SQLite PRAGMA journal_mode#136
π‘οΈ Sentinel: [HIGH] Fix SQL injection in SQLite PRAGMA journal_mode#136mapleleaflatte03 wants to merge 2 commits into
Conversation
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: SQL injection vulnerability in
observability_store.pywhere theMERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEenvironment variable was directly interpolated into aPRAGMA journal_modequery.π― Impact: An attacker with the ability to control environment variables could execute arbitrary SQLite commands (e.g.,
WAL; DROP TABLE...) leading to data loss or corruption.π§ Fix: Added strict allowlist validation for the environment variable against valid SQLite journal modes (
DELETE,TRUNCATE,PERSIST,MEMORY,WAL,OFF,DEFAULT,""). If an invalid value is provided, it defaults safely toWAL.β Verification: Verified by running the local test suites to ensure normal application behavior is not disrupted, and confirmed visually via
git diff.PR created automatically by Jules for task 1124750764782372377 started by @mapleleaflatte03