Fix RTL plugin crash with empty formatted text sections#6545
Closed
Omkarthipparthi wants to merge 3 commits intomaplibre:mainfrom
Closed
Fix RTL plugin crash with empty formatted text sections#6545Omkarthipparthi wants to merge 3 commits intomaplibre:mainfrom
Omkarthipparthi wants to merge 3 commits intomaplibre:mainfrom
Conversation
…ipparthi/maplibre-gl-js into fix-rtl-empty-formatted-sections
Collaborator
|
Have we tried opening an issue to the RTL plugin repo? |
Contributor
Author
|
@HarelM |
Collaborator
|
While this might have taken a little bit of time a new version will be released soon which will solve this issue, so I'm closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes crash when using RTL text plugin with formatted
text-fieldexpressions where all sections evaluate to empty strings.Closes #6444
Problem
When using the RTL text plugin (
@mapbox/mapbox-gl-rtl-text@0.3.0) with a formattedtext-fieldwhere all sections are empty (e.g., bothnameandrefare null), the application crashes with:Root Cause
The RTL plugin's
processStyledBidirectionalTextcan return either:[text, sectionIndex](expected format){text, sectionIndex}(some plugin versions/edge cases)The shaping code in
src/symbol/shaping.tsonly handled tuples, causingtaggedLine.textto beundefinedwhen objects were returned, leading to crashes when later code accessedthis.text.length.Solution
Added defensive normalization logic (lines 331-361 in
shaping.ts) to:[text, sectionIndex]and object{text, sectionIndex}formats''for text, empty array[]for sectionIndexTesting
@mapbox/mapbox-gl-rtl-text@0.3.0Test Cases Verified
Checklist
textproperty for formatted text with multiple empty sections and right to left plugin #6444