Update node to v24. Add support for Windows arm64 node binary build and publish. Update Linux node binary to be built on ubuntu 24.04 by acalcutt · Pull Request #3760 · maplibre/maplibre-native

acalcutt · 2025-08-26T19:00:55Z

This PR updates node current version to v24 and adds a windows arm64 binary to the build. It also updates the Linux binary to ubuntu 24.04. It includes changes from #3759 and changes from #3692 with some of the (Get-VendorPackages.ps1) changes reverted.

Closes #3687

This PR does the following

Updates the built node versions to node 20, 22, and 24 . Note that node 18 was removed because it is no longer supported and also did not seem to have node build candidates for windows arm64
Updates NAN to 2.23.0 to support node v24
Reverts the change to use @mapbox/node-pre-gyp and points back to my @acalcutt/node-pre-gyp. This is to allow node-pre-gyp to work in node v24. The fix has been committed in the main branch of @mapbox/node-pre-gyp , but as noted in v2.0.1 did not properly release on npm mapbox/node-pre-gyp#907 we can't seem to get anyone who has permission to get a new version published there. It could make sense in the future to make a @maplibe version of node-pre-gyp instead of using my version.
Adds presets for Linux and windows node builds in CMakePresets.json like existed for macOS already. Builds upon Windows Arm64 presets #3692 form windows arm64 node version.
For windows arm64 workflows, "ilammy/msvc-dev-cmd" was changed to add "arch: amd64_arm64" option, which sets VSCMD_ARG_TGT_ARCH environment variable and allows 'Get-VendorPackages.ps1' to built for the proper arm64 target/triplet. Without doing this Get-VendorPackages.ps1 was picking an x64 triplets.
I added some debug information to the windows triplet files to help understand what was going on with the builds. At first it was hard to tell the VSCMD_ARG_TGT_ARCH was causing the wrong triplet to be loaded, which cause it to build for the wrong platform. This shows in the configure step on windows, like

Updated platform/node/cmake/module.cmake to add support for windows arm64
Removes some old workarounds from the workflow which no longer seem to be needed, like setting a specific cmake version and strawberry perl fixes.
Updated version of boost to fix a lot of "[The contents of are available only with C++23 or later.] warnings I was seeing in the windows arm64 build. I found in Visual Studio compiler warning The contents of <stdfloat> are available only with C++23 or later. lballabio/QuantLib#1827 that error existed in boost 1.83, which is what version our maplibre-native boost package was tacked to, and was fixed in 1.84. https://github.com/maplibre/maplibre-gl-native-boost was already updated to 1.86, so I just updated to that latest commit.
When running tests on windows arm, the version of pal1000/mesa-dist-win was failing because that mesa3d release is not compatible with arm. I changed this to use mmozeiko/build-mesa for windows arm tests, which was suggested for arm64 on the pal1000 release

github-actions · 2025-08-27T00:22:46Z

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +2.02Ki  +0.0%    +884    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3760-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +45% +51.9Mi  +445% +26.6Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3760-compared-to-legacy.txt

github-actions · 2025-08-27T00:26:55Z

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0024         +0.0022             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3760-compared-to-main.txt

for more information, see https://pre-commit.ci

This reverts commit b40f5c1.

This reverts commit a9692f1.

.github/workflows/node-release.yml

acalcutt · 2025-09-16T01:14:16Z

Can anyone approve this? Also, @louwers there are two failing tests that i don't think are related to this PR as I see them failing elsewhere

I did have one final question about the presets. Do you think the presets should include "CMAKE_CXX_COMPILER_LAUNCHER": "sccache" or should that be added in the workflow?

Copilot

Pull Request Overview

This PR updates Node.js support to versions 20, 22, and 24 while removing support for Node 18, and adds Windows ARM64 binary builds to the CI/CD pipeline. The changes enable MapLibre Native to support newer Node.js versions and expand platform compatibility.

Updates Node.js target versions from 18, 20, 22 to 20, 22, 24
Adds Windows ARM64 build support with new CI workflows and CMake presets
Updates Linux builds to use Ubuntu 24.04 instead of 22.04

Reviewed Changes

Copilot reviewed 12 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
platform/node/scripts/publish.sh	Updates Node.js target versions in build script
platform/node/package.json	Updates version, dependency, and Node engine requirements
platform/node/cmake/module.cmake	Adds Windows ARM64 architecture detection
platform/node/README.md	Updates documentation for platform support
platform/node/CMakeLists.txt	Updates minimum Node ABI and NAN version
platform/node/CHANGELOG.md	Documents changes for new version
platform/node/.nvmrc	Updates Node version to 24
docs/mdbook/src/platforms/windows/build-msvc-arm64.md	Adds comprehensive Windows ARM64 build documentation
CMakePresets.json	Adds presets for Linux, Windows, and Windows ARM64 node builds
.github/workflows/node-release.yml	Updates CI to support Ubuntu 24.04 and Windows ARM64
.github/workflows/node-ci.yml	Updates CI workflows with ARM64 support and new test configurations
.github/actionlint.yaml	Updates runner configuration for new platforms

Files not reviewed (1)

platform/node/package-lock.json: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

platform/node/cmake/module.cmake

.github/workflows/node-ci.yml

louwers

I can't really review the Windows stuff...

So... LGTM. I'll get it merged, will look into the linux workflow.

louwers · 2025-09-19T20:48:59Z

#3825 wil probably fix linux-ci

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…to cachly-production-v2 * 'main' of https://github.com/maplibre/maplibre-native: (186 commits) [node] Add options parameter to addImage method in Node.js type definitions (maplibre#3868) Fix .gitmodules submodule names to match actual paths after vendor reorganization (maplibre#3860) Fix warnings in MapLibre iOS example app (maplibre#3857) Handle style builder exceptions (maplibre#3855) Release MapLibre Android 12.0.0 (maplibre#3853) Bump minimum Android SDK version from 21 to 23 (maplibre#3849) Add --actionJournalDir argument to glfw binary (maplibre#3852) Fix crash in camera position (maplibre#3847) docs: remove `@param` for property (maplibre#3843) Ios 6 19 1 (maplibre#3846) Release MapLibre iOS 6.19.0 (maplibre#3845) Remove bazel-out from xcframework (maplibre#3841) fix misplaced LineOffset and LineGapWidth (maplibre#3840) Add validate-backend-options.cmake script (maplibre#3828) Manually free bound resources (maplibre#3831) Move dependencies from maplibre-native-base to vendor (maplibre#3829) chore(security): configure dependency cooldown settings (maplibre#3824) Bump taiki-e/install-action from 2.61.7 to 2.62.1 in the github-actions group (maplibre#3826) Update node to v24. Add support for Windows arm64 node binary build and publish. Update Linux node binary to be built on ubuntu 24.04 (maplibre#3760) fix linux-ci (maplibre#3825) ...

birkskyum and others added 28 commits August 29, 2025 09:22

all changes

6ed115e

cleanup

3d32eee

remove fixup

19f9c16

fixes

e29c63e

cleanup

9b4f689

add vulkan preset

90ddba9

add arm64 build guide

778afc8

move windows presets together

4ca3390

[pre-commit.ci] auto fixes from pre-commit.com hooks

a117488

for more information, see https://pre-commit.ci

cleanup windows.cmake

c35dcdf

[pre-commit.ci] auto fixes from pre-commit.com hooks

8ad6c8f

for more information, see https://pre-commit.ci

move build guide eto docs

a5f3e11

add msvc arm64 runner for opengl/vulkan

b4c1dc1

Revert "add msvc arm64 runner for opengl/vulkan"

5ef11cf

This reverts commit b40f5c1.

update workflow runners

b951821

update NAN to 2.23.0

c61c6e1

remove excluded abi 137 (node v24)

188d01b

use @acalcutt/node-pre-gyp to support node v24

ac74554

Update package-lock.json

7853cc5

Update publish.sh

4e1b26d

remove cmake specified version

dca0899

add arm64 detection to module.cmake

12b7366

add windows-11-arm to workflows

6a98a8e

try adding DCMAKE_PREFIX_PATH on arm windows

7c6920e

test ai fixes

1ada8b7

ai test 2

ce8a246

ai test 3

e073936

Revert "try adding DCMAKE_PREFIX_PATH on arm windows"

bcea78f

This reverts commit a9692f1.

acalcutt added 4 commits September 1, 2025 22:22

Update windows.cmake

d97b296

Update windows.cmake

c3bbb2f

Revert windows-ci.yml

986d714

Revert windows.cmake

32956a0

louwers reviewed Sep 2, 2025

View reviewed changes

.github/workflows/node-release.yml Outdated Show resolved Hide resolved

acalcutt added 3 commits September 2, 2025 10:30

Merge branch 'main' into test-arm-node

ba1fc0f

Merge branch 'main' into test-arm-node

24750c5

Merge branch 'main' into test-arm-node

7272840

acalcutt mentioned this pull request Sep 3, 2025

Environment variable for building npm package (rather than just downloading the binary) #3770

Open

acalcutt added 4 commits September 6, 2025 10:59

Merge branch 'main' into test-arm-node

f75ba9f

Merge branch 'main' into test-arm-node

8918ba8

Merge branch 'main' into test-arm-node

789acae

Merge branch 'main' into test-arm-node

01cc694

Merge branch 'main' into test-arm-node

160c883

github-actions bot added documentation Improvements or additions to documentation build Related to build, configuration or CI/CD node github_actions Pull requests that update GitHub Actions code windows labels Sep 19, 2025

louwers requested a review from Copilot September 19, 2025 18:47

Copilot AI reviewed Sep 19, 2025

View reviewed changes

platform/node/cmake/module.cmake Outdated Show resolved Hide resolved

.github/workflows/node-ci.yml Show resolved Hide resolved

.github/workflows/node-ci.yml Show resolved Hide resolved

louwers approved these changes Sep 19, 2025

View reviewed changes

acalcutt and others added 4 commits September 19, 2025 18:38

Merge branch 'main' into test-arm-node

4fb4bba

Update platform/node/cmake/module.cmake

265e9f7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

publish binaries as draft

73c545d

Update node-release.yml

7fc828a

acalcutt merged commit 6ee5505 into maplibre:main Sep 20, 2025
44 of 48 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update node to v24. Add support for Windows arm64 node binary build and publish. Update Linux node binary to be built on ubuntu 24.04#3760

Update node to v24. Add support for Windows arm64 node binary build and publish. Update Linux node binary to be built on ubuntu 24.04#3760
acalcutt merged 108 commits intomaplibre:mainfrom
WifiDB:test-arm-node

acalcutt commented Aug 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

acalcutt commented Sep 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

louwers left a comment

Uh oh!

louwers commented Sep 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

acalcutt commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bloaty Results 🐋

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3760-compared-to-main.txt

Uh oh!

github-actions bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

acalcutt commented Sep 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

louwers left a comment

Choose a reason for hiding this comment

Uh oh!

louwers commented Sep 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

acalcutt commented Aug 26, 2025 •

edited

Loading

github-actions bot commented Aug 27, 2025 •

edited

Loading

github-actions bot commented Aug 27, 2025 •

edited

Loading