Skip to content

fix:fix vt symbol value is function-type update #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deyihu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix:fix vt symbol value is function-type update #2849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a48edb
fix:fix vt symbol value is function-type update
deyihu Mar 19, 2026
6ef2946
updates
deyihu Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion packages/vt/src/layer/plugins/painters/Painter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ const levelNFilter = mesh => {
return mesh.properties.level > 0;
};

function isObjectOrArray(v) {
return v && (maptalks.Util.isObject(v) || Array.isArray(v));
}

class Painter {
static getBloomSymbol() {
return ['bloom'];
Expand Down Expand Up @@ -813,13 +817,46 @@ class Painter {
if (!this._symbol) {
return false;
}
const refresh = this._isNeedRefreshStyle(this.symbolDef[i] || {}, all);
let refresh = this._isNeedRefreshStyle(this.symbolDef[i] || {}, all);
if (this._invisibleWhenCreated[i] && all.visible !== false) {
this._invisibleWhenCreated[i] = false;
return true;
}
this.symbolDef[i] = copyJSON(all);
const symbol = this._symbol[i];
const newSymbol = this.symbolDef[i];
const keys = Object.keys(newSymbol);

for (let j = 0, len = keys.length; j < len; j++) {
const key2 = keys[j];
const v2 = newSymbol[key2];
//function-type the original value
const key1 = `_${key2}`;
const v1 = symbol[key1];
if (v2 === v1) {
continue;
}
//function-type or array properties diff
if (isObjectOrArray(v1) && isObjectOrArray(v2)) {
try {
const str1 = JSON.stringify(v1);
const str2 = JSON.stringify(v2);
if (str1 === str2) {
continue;
}

} catch (error) {
console.error(error);
}
}
if (isObjectOrArray(v1) && isFunctionDefinition(v1) && !isFunctionDefinition(v2)) {
refresh = true;
}
if (isObjectOrArray(v2) && isFunctionDefinition(v2) && !isFunctionDefinition(v1)) {
refresh = true;
}

}
for (const p in symbol) {
delete symbol[p];
}
Expand Down