Dev Tools: Set <meta name="herb-default-editor"> for Herb#51
Merged
Conversation
marcoroth
force-pushed
the
set-herb-default-editor
branch
from
27cdc19 to
7eb3512
Compare
marcoroth
added a commit
to marcoroth/herb
that referenced
this pull request
Oct 22, 2025
This pull request updates the Herb Dev Tools to allow users to select their preferred editor. Tools like ReActionView can set a new `<meta name="herb-default-editor">` tag that will be used for the `auto` option, so you can use the new [`ActiveSupport::Editor` in Rails 8.1](https://github.com/rails/rails/blob/b22fd5a519f92e5c51c62e3b74b4407e492b89e2/activesupport/lib/active_support/editor.rb) or fallback to the `RAILS_EDITOR` or `EDITOR` environment variables (see accompanying pull request in ReActionView that sets this: marcoroth/reactionview#51) <img width="2296" height="1138" alt="CleanShot 2025-10-22 at 15 29 19@2x" src="https://github.com/user-attachments/assets/5219c85e-6150-4ae1-9a8f-59cd2ce4e75e" /> <img width="2296" height="1138" alt="CleanShot 2025-10-22 at 15 29 30@2x" src="https://github.com/user-attachments/assets/8bb91045-9fda-4f89-bb35-42b91287b87d" /> Resolves #599 Resolves #710 Resolves marcoroth/reactionview#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See marcoroth/herb#715
Resolves #3