Skip to content

Fix pip freeze logic for #500 - #1461

Open
Dingding-leo wants to merge 1 commit into
marqo-ai:mainlinefrom
Dingding-leo:fix-run-marqo-pip-freeze
Open

Fix pip freeze logic for #500#1461
Dingding-leo wants to merge 1 commit into
marqo-ai:mainlinefrom
Dingding-leo:fix-run-marqo-pip-freeze

Conversation

@Dingding-leo

Copy link
Copy Markdown

Fixes #500.

Copilot AI review requested due to automatic review settings July 26, 2026 01:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cdbcd8bcf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

MARQO_LOG_LEVEL=`echo "$MARQO_LOG_LEVEL" | tr '[:upper:]' '[:lower:]'`

if [ "$MARQO_LOG_LEVEL" = "debug" ]; then
pip freeze

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Freeze the uv-managed environment instead

In the production image, components/marqo/Dockerfile:54 creates the application .venv with uv sync, which does not seed a pip executable, while line 61 only prepends that environment to PATH. Consequently, this command falls through to the base image's system pip and reports system packages—typically omitting the FastAPI, Uvicorn, and other dependencies actually running Marqo. This matches the CLI documentation: uv venv --help says --seed installs pip, while uv pip freeze --help describes freezing packages installed in an environment. Target the uv-managed environment (for example with uv pip freeze) so the debug diagnostics reflect the running application.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Squash pip freeze on startup [ENHANCEMENT]

2 participants