fix: gate pip freeze output behind LOG_LEVEL=debug on startup - #1466
Open
0x5t4l1n wants to merge 1 commit into
Open
fix: gate pip freeze output behind LOG_LEVEL=debug on startup#14660x5t4l1n wants to merge 1 commit into
0x5t4l1n wants to merge 1 commit into
Conversation
Resolves marqo-ai#500. Marqo startup logs were cluttered because pip freeze ran unconditionally. Move the pip freeze call inside a LOG_LEVEL=debug guard so it only prints when the operator explicitly requests verbose output, keeping default-level startup clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #500 —
pip freezeran unconditionally on every startup, cluttering default-level logs with hundreds of package lines.Change in
components/marqo/run_marqo.sh: Wrap thepip freezecall inif [ "$MARQO_LOG_LEVEL" = "debug" ]so it only prints when the operator explicitly opts into verbose output.Test plan
pip freezeoutput absentMARQO_LOG_LEVEL=debug—pip freezeoutput present