Merged
Conversation
ricalessandri
previously approved these changes
Jan 9, 2026
Collaborator
ricalessandri
left a comment
ricalessandri
left a comment
There was a problem hiding this comment.
Overall it looks good to me; I'm approving so you can merge. But please see my small non-binding suggestions; also, I guess you did this on purpose but, don't you want to add test for the other vinyl polymers (PMA, PMMA, etc.) ?
Co-authored-by: Riccardo Alessandri <ric.alessandri@gmail.com>
ricalessandri
approved these changes
Mar 31, 2026
Member
Author
|
@ricalessandri it's the fragment remaining when using a sec-butyl lithium initiator in anionic polymerization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the martini library with acrylic polymers. The 1,2-polybutadine model is already published. The rest is preliminary hence they have a warning. Only exception is PS, which performs much better than the old model. Hence, not having a warning seems ok.