Merged
Conversation
Lipgloss and glamour have internal TTY detection that automatically strips ANSI color codes when stdout is piped, regardless of what the application code requests. This made --color=always ineffective. The fix uses lipgloss.SetColorProfile() to configure the global color profile early, before any rendering: - "always": Uses termenv.EnvColorProfile() which detects terminal color capabilities from environment variables (COLORTERM, TERM) without checking if stdout is a TTY. This respects the terminal's actual color support while allowing colors through pipes. - "never": Forces termenv.Ascii to disable all colors globally. - "auto": Lets lipgloss use its default TTY-based detection. For glamour markdown rendering, --color=always now also passes WithColorProfile(termenv.EnvColorProfile()) to force colors. This simplification also removes the redundant applyColorToIcon and applyColorToStyle wrapper functions since the global profile now handles color stripping automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lipgloss and glamour have internal TTY detection that automatically strips ANSI color codes when stdout is piped, regardless of what the application code requests. This made
--color=alwaysineffective.The fix uses
lipgloss.SetColorProfile()to configure the global color profile early, before any rendering:"always": Uses
termenv.EnvColorProfile()which detects terminal color capabilities from environment variables (COLORTERM, TERM) without checking if stdout is a TTY. This respects the terminal's actual color support while allowing colors through pipes."never": Forces
termenv.Asciito disable all colors globally."auto": Lets lipgloss use its default TTY-based detection.
For glamour markdown rendering,
--color=alwaysnow also passesWithColorProfile(termenv.TrueColor)to force colors.This simplification also removes the redundant
applyColorToIconandapplyColorToStylewrapper functions since the global profile now handles color stripping automatically.