Fix SASL on libera.chat #572
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While deploying a bot to libera.chat we were unable to connect via SASL because the ACK was never recognized. The reason for that rested on this weird space. This patch checks that a trimmed version of the second argument is equal to `sasl`. This is enough for our personal purposes.
|
Pretty sure this project is dead. Its' been literally a year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While deploying an IRC bot to libera.chat (w/@Lartu) we were unable to connect via SASL because the ACK was never recognized.
The reason for that rested on a check that expected a weird leftover space character.
This PR checks that a trimmed version of the third argument is equal to
sasl.This is enough for our personal purposes but i'm not sure if it is a proper fix.