Skip to content

Searching with keywords#23

Open
garrett wants to merge 4 commits intomarusak:searching_with_keywordsfrom
garrett:searching_with_keywords
Open

Searching with keywords#23
garrett wants to merge 4 commits intomarusak:searching_with_keywordsfrom
garrett:searching_with_keywords

Conversation

@garrett
Copy link

@garrett garrett commented Oct 7, 2019

I still can't push to your branch (or even see it in the PR dropdowns unless I manually mess with the URL), so here's a PR to your PR that

  • fixes search sizing
  • removes top nav fade
  • restructures the search class to only apply when inside the nav (as "search" is quite generic... and we might want to think of another name for the class overall, like ct-nav-search)

@marusak marusak force-pushed the searching_with_keywords branch 3 times, most recently from 24ede90 to 9106c4c Compare October 9, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants