add upgrade script #313
Open
add upgrade script #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an upgrade script to the smart contract along with minor improvements and formatting changes in related files. Key changes include:
- A new upgrade script (upgrade.ts) that calls the upgradeSC method on the smart contract.
- Formatting and style updates in Metadata.ts and deweb-interface.ts.
- Addition of an "upgrade" script command in package.json and a no-console rule override in the ESLint configuration.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| smart-contract/src/upgrade.ts | Added upgrade script to call the upgradeSC method |
| smart-contract/src/e2e/helpers/serializable/Metadata.ts | Reformatted constructor for brevity |
| smart-contract/package.json | Added upgrade script command |
| smart-contract/assembly/contracts/deweb-interface.ts | Adjusted assertions formatting and unused parameter naming |
| smart-contract/assembly/tests/deweb-interface/helpers/delete-file.ts | Removed an extra newline |
| smart-contract/.eslintrc.cjs | Overrode ESLint no-console rule for src files |
| assert(hashLocation.length == 32, 'Invalid filpath sha256 hash. should be 32 bytes'); | ||
| assert( | ||
| hashLocation.length == 32, | ||
| 'Invalid filpath sha256 hash. should be 32 bytes', |
There was a problem hiding this comment.
The error message contains a spelling mistake ('filpath' should be 'filepath'). Correcting this will improve clarity.
Suggested change
| 'Invalid filpath sha256 hash. should be 32 bytes', | |
| 'Invalid filepath sha256 hash. should be 32 bytes', |
Copilot uses AI. Check for mistakes.
| assert(hashLocation.length == 32, 'Invalid filpath sha256 hash. should be 32 bytes'); | ||
| assert( | ||
| hashLocation.length == 32, | ||
| 'Invalid filpath sha256 hash. should be 32 bytes', |
There was a problem hiding this comment.
The error message contains a typo ('filpath' should be 'filepath'). A correction here will enhance readability.
Suggested change
| 'Invalid filpath sha256 hash. should be 32 bytes', | |
| 'Invalid filepath sha256 hash. should be 32 bytes', |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.