Skip to content

Fix UIBackgroundConfiguration.listPlainCell deprecation warnings #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aokj4ck wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix UIBackgroundConfiguration.listPlainCell deprecation warnings #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Mastodon/Diffable/Profile/ProfileFieldSection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ extension ProfileFieldSection {
}

// set background
var backgroundConfiguration = UIBackgroundConfiguration.listPlainCell()
var backgroundConfiguration = UIBackgroundConfiguration.listCell()
backgroundConfiguration.backgroundColor = UIColor.secondarySystemBackground
cell.backgroundConfiguration = backgroundConfiguration

Expand Down Expand Up @@ -126,7 +126,7 @@ extension ProfileFieldSection {
.store(in: &cell.disposeBag)

// set background
var backgroundConfiguration = UIBackgroundConfiguration.listPlainCell()
var backgroundConfiguration = UIBackgroundConfiguration.listCell()
backgroundConfiguration.backgroundColor = UIColor.secondarySystemBackground
cell.backgroundConfiguration = backgroundConfiguration

Expand All @@ -136,7 +136,7 @@ extension ProfileFieldSection {
let addEntryCellRegistration = UICollectionView.CellRegistration<ProfileFieldAddEntryCollectionViewCell, ProfileFieldItem> { cell, indexPath, item in
guard case .addEntry = item else { return }

var backgroundConfiguration = UIBackgroundConfiguration.listPlainCell()
var backgroundConfiguration = UIBackgroundConfiguration.listCell()
backgroundConfiguration.backgroundColorTransformer = .init { [weak cell] _ in
guard let cell = cell else {
return .secondarySystemBackground
Expand Down
2 changes: 0 additions & 2 deletions Mastodon/Scene/Onboarding/Login/MastodonLoginViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ class MastodonLoginViewController: UIViewController {
setupOnboardingAppearance()

title = L10n.Scene.Login.title

guard let view = view as? MastodonLoginView else { return }
}

override func viewWillAppear(_ animated: Bool) {
Expand Down
2 changes: 1 addition & 1 deletion Mastodon/Scene/Root/Sidebar/View/SidebarListCollectionViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ extension SidebarListCollectionViewCell {
contentConfiguration = newConfiguration

// remove background
var newBackgroundConfiguration = UIBackgroundConfiguration.listSidebarCell().updated(for: state)
var newBackgroundConfiguration = UIBackgroundConfiguration.listAccompaniedSidebarCell().updated(for: state)
newBackgroundConfiguration.backgroundColor = .clear
backgroundConfiguration = newBackgroundConfiguration
}
Expand Down
2 changes: 1 addition & 1 deletion Mastodon/Scene/Search/Search/Cell/TrendCollectionViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ extension TrendCollectionViewCell {
override func updateConfiguration(using state: UICellConfigurationState) {
super.updateConfiguration(using: state)

var backgroundConfiguration = UIBackgroundConfiguration.listGroupedCell()
var backgroundConfiguration = UIBackgroundConfiguration.listCell()
backgroundConfiguration.backgroundColorTransformer = .init { _ in
if state.isHighlighted || state.isSelected {
return SystemTheme.tableViewCellSelectionBackgroundColor
Expand Down
2 changes: 1 addition & 1 deletion ...on/Scene/Search/SearchDetail/SearchHistory/Cell/SearchHistoryUserCollectionViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class SearchHistoryUserCollectionViewCell: UICollectionViewCell {
override func updateConfiguration(using state: UICellConfigurationState) {
super.updateConfiguration(using: state)

var backgroundConfiguration = UIBackgroundConfiguration.listGroupedCell()
var backgroundConfiguration = UIBackgroundConfiguration.listCell()
backgroundConfiguration.backgroundColorTransformer = .init { _ in
if state.isHighlighted || state.isSelected {
return SystemTheme.tableViewCellSelectionBackgroundColor
Expand Down
2 changes: 1 addition & 1 deletion Mastodon/Scene/Search/SearchDetail/SearchHistory/SearchHistorySection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ extension SearchHistorySection {
contentConfiguration.text = "#" + hashtag.name
cell.contentConfiguration = contentConfiguration

var backgroundConfiguration = UIBackgroundConfiguration.listGroupedCell()
var backgroundConfiguration = UIBackgroundConfiguration.listCell()
backgroundConfiguration.backgroundColorTransformer = .init { [weak cell] _ in
guard let state = cell?.configurationState else {
return .secondarySystemGroupedBackground
Expand Down
2 changes: 1 addition & 1 deletion Mastodon/Scene/SuggestionAccount/SuggestionAccountViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ final class SuggestionAccountViewModel: NSObject {
await withTaskGroup(of: Void.self, body: { taskGroup in
for account in tmpAccounts {
taskGroup.addTask {
try? await DataSourceFacade.responseToUserViewButtonAction(
_ = try? await DataSourceFacade.responseToUserViewButtonAction(
dependency: dependency,
account: account,
buttonState: .follow
Expand Down
3 changes: 0 additions & 3 deletions MastodonSDK/Sources/MastodonUI/View/Content/NewsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ public final class NewsView: UIView {
}()

let imageView = MediaView()

// let imageView = UIImageView()
// var imageViewMediaConfiguration: MediaView.Configuration?

public func prepareForReuse() {
providerFaviconImageView.tag = (0..<Int.max).randomElement() ?? -1
Expand Down
Loading