Skip to content

Conversation

esoteric-ephemera
Copy link
Contributor

@esoteric-ephemera esoteric-ephemera commented Aug 14, 2025

Can be merged once emmet-core #1267 is merged/released.

  • Migrates sole maggma import to emmet.core, removes maggma from dependencies.
  • Adds ConversionElectrodeRester to query the conversion_electrodes endpoint

@esoteric-ephemera esoteric-ephemera changed the title Remove maggma dependence Remove maggma dependence, add conversion electrode rester Aug 27, 2025
@esoteric-ephemera
Copy link
Contributor Author

esoteric-ephemera commented Aug 27, 2025

@tschaume there seem to be some issues with the conversion_electrodes endpoint, perhaps that's why a client search feature wasn't added for it before? Have basically flagged these in the class itself under _exclude_search_fields

  • material_ids is listed as a valid search term in the docs, but there are neither material_id or material_ids fields in the schema
  • formula, chemsys, and elements do not return any matches despite manually checking values from OpenData
  • stability_charge and stability_discharge are also not working
  • Similarly, passing exclude_elements will return the entire collection

Copy link
Member

@tschaume tschaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The issues you found are likely due to the the query operators defined here. The multi-material query isn't needed, for instance. It could be that it was a simple copy-paste oversight when the endpoint was added in emmet PR 814.

@kbuma maybe you could take a closer look at the operator definitions for the conversion electrodes endpoints as part of your cleanup in emmet PR 1282? Thanks!

@@ -66,7 +66,7 @@ def client_search_testing(
f"Parameter '{param}' with type '{param_type}' was not "
"properly identified in the generic search method test."
)

print(q)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants