-
Notifications
You must be signed in to change notification settings - Fork 49
Remove maggma dependence, add conversion electrode rester #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@tschaume there seem to be some issues with the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The issues you found are likely due to the the query operators defined here. The multi-material query isn't needed, for instance. It could be that it was a simple copy-paste oversight when the endpoint was added in emmet PR 814.
@kbuma maybe you could take a closer look at the operator definitions for the conversion electrodes endpoints as part of your cleanup in emmet PR 1282? Thanks!
tests/materials/core_function.py
Outdated
@@ -66,7 +66,7 @@ def client_search_testing( | |||
f"Parameter '{param}' with type '{param_type}' was not " | |||
"properly identified in the generic search method test." | |||
) | |||
|
|||
print(q) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
Can be merged onceemmet-core
#1267 is merged/released.maggma
import toemmet.core
, removesmaggma
from dependencies.ConversionElectrodeRester
to query the conversion_electrodes endpoint