Transformation makers and SQS #1322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esoteric-ephemera
force-pushed
the
sqs
branch
2 times, most recently
from
6e9f7d8 to
d0e5f5d
Compare
Member
|
Just noting the There is some overlap here the existing class both applies the transformation and then runs a calculation which is more limiting. |
Collaborator
Author
|
Yep! The idea here was more flexibility like you're saying, specifically for SQS transformations (the output of the SQS transformation in particular is different from the other transformation classes) |
esoteric-ephemera
force-pushed
the
sqs
branch
from
af05690 to
96e9c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transformerclass which only needs a transformation as input to run for ~90% of pymatgen transformations