Update safe extension to remove event listeners in MathML input - #1548
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1548 +/- ##
===========================================
- Coverage 86.92% 86.92% -0.01%
===========================================
Files 390 390
Lines 87853 87857 +4
Branches 4984 4983 -1
===========================================
- Hits 76370 76368 -2
- Misses 11464 11470 +6
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zorkow
approved these changes
Aug 12, 2026
zorkow
left a comment
Member
There was a problem hiding this comment.
lgtm.
One typo, but I might be wrong.
Co-authored-by: Volker Sorge <v.sorge@mathjax.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for filtering out event listeners like
onclickfrom MathML input. By default these are now filtered out. This behavior is controlled byon*entry in thefilterAttributesmap. One could useto remove this filter. There is no configuration parameter for this, as there are completely unsafe, so removing this filter should be hard to do.
The PR also fixes the alignment of
@returnsjsDoc declarations.