Conversation
chippison
commented
Feb 3, 2026
55d6aaf to
d0d793a
Compare
a7823d0 to
0f29af8
Compare
nathangavin
previously approved these changes
Feb 19, 2026
Contributor
nathangavin
left a comment
There was a problem hiding this comment.
Looks good to me, meets the requirements and the logic for determining flat vs expanded makes sense.
sgiehl
requested changes
Feb 19, 2026
Member
There was a problem hiding this comment.
This one looks invalid. Flatten report is chosen, but in the export link there is no flat=1, but expanded=1
…hen format is csv or tsv
…hat are not CSV and TSV
…e expand option to be true when it is other formats
… our new logic. we also don't want to change default behaviour if the data does not have a subtable
…nd subtable option w/o forcing the user to change selection if it has added some selections
This is helpful for exporting RowEvolution data.
…t flaky-ness due to waitForTimeout
…stead of defaulting to 'option_flat' being ticked
updating tests
…in the URL. added fix so that we hide 'Flatten report' input control when there is actually no subtable in the report
updating tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DEV-14698
When exporting a report in CSV and TSV, we would want to:
For other formats ('JSON', 'RSS', 'XML', 'HTML')
NOTE:
CSV/TSV exports do not support expanded subtables, so we always export the flattened table for these formats. This changes the output from top‑level referrers to flattened subtable rows and removes goal‑specific columns that aren’t present in the flattened export. The new fixtures (tests/UI/expected-screenshots/ReportExporting_Referrers.getWebsites_exported.csv.txt and tests/UI/expected-screenshots/ReportExporting_Referrers.getWebsites_exported.tsv.txt) reflect the intended CSV/TSV behavior.
Acceptance Criteria
Should only happen when a datatable to be exported has subtables. We don't change behaviour when table has no subtable
Checklist
Review