Conversation
sgiehl
left a comment
There was a problem hiding this comment.
Generally looks fine. Left a small suggestion.
Besides that the whole plugin actually misses some end-to-end tests. So triggering a real archiving and ensuring that the metrics are afterwards correctly stored.
I'm not adding an approval here for now, as bumping the version to 5.8.0-b2 should be done after 5.8.0-b1 🙈
Thanks! I believe e2e is covered from the API level inwards, do you want larger scoped tests? The details about the correct values being stored are handled in other tests. testArchiveReportsWritesMetricsOnceAndDoesNotWriteAgainWhenReusingDbArchive |
sgiehl
left a comment
There was a problem hiding this comment.
Note: We need to release b2, once this is merged.
Description
This PR adds archiving metrics support for identifying temporary archives via a new is_temporary flag
performance analysis and comparisons.
Checklist
Review