Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Requesting a non-API endpoint in Matomo using a regular
token_authis, by default, only allowed with a "view only" access backed account. For higher privileges required activatingenable_framed_allow_write_admin_token_auth:matomo/config/global.ini.php
Lines 553 to 558 in 5634dff
This is a global setting, for everything, and cannot be limited to certain plugins if one wants to keep the risk low.
This PR adds a new config option with a naming not specifically tied to "framed pages", that allows configuring a list of
Module.Actionendpoints to be accessible bytoken_auth. Might need some future improvements to adjust the error message, as that always hints at the widgetization/embedding, but might be useful for any controller that needs token authentication and does not fit in the API layer.It still keeps the super user access guard in place. Only write/admin level tokens are possible.
Checklist
Review