Skip to content

etracker proxy domain - etracker code update #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ben-dw wants to merge 16 commits into
base: 5.x-dev
Choose a base branch
from
Draft

etracker proxy domain - etracker code update #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
aaac6ca
Update en.json
ben-dw Nov 3, 2025
4e3dd31
Update en.json
ben-dw Nov 3, 2025
5b9cfb4
Update EtrackerConfigurationVariable.php
ben-dw Nov 3, 2025
bd760d2
Update EtrackerTag.web.js
ben-dw Nov 3, 2025
9fa206e
Update EtrackerTag.web.js
ben-dw Nov 3, 2025
417b496
Update en.json
ben-dw Nov 3, 2025
fd41370
Update en.json
ben-dw Nov 3, 2025
eee1bb0
Update EtrackerTag.web.js
ben-dw Nov 3, 2025
c0e34cd
Update EtrackerTag.web.js
ben-dw Nov 26, 2025
4bf4513
Update EtrackerConfigurationVariable.php
ben-dw Dec 1, 2025
dc87e45
Update en.json
ben-dw Dec 1, 2025
2bdd7ac
Update EtrackerTag.web.js
ben-dw Dec 1, 2025
856858d
Merge branch 'matomo-org:5.x-dev' into ben-dw-etracker-proxy-domain1
ben-dw Dec 1, 2025
4818dc5
Update en.json
ben-dw Dec 1, 2025
e1c779c
Update EtrackerConfigurationVariable.php
ben-dw Dec 2, 2025
bab29d7
Update EtrackerConfigurationVariable.php
ben-dw Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion Template/Tag/EtrackerTag.web.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
}
}
}
//Proxy Domain
if(etrackerConfig.enableEtrackerProxyDomain){
window['et_proxy_redirect'] = "\/\/"+etrackerConfig.etrackerProxyDomain;
}

if (!hasBeenLoaded && etrackerID) {
hasBeenLoaded = true;
Expand All @@ -44,7 +48,18 @@
if (etrackerConfig.etrackerDNT) {
script.setAttribute('data-respect-dnt', 'true');
}
script.src = '//code.etracker.com/code/e.js';
//custom cookie domain
if (etrackerConfig.enableEtrackerCookieDomain) {
script.setAttribute('data-cookie-domain', etrackerConfig.etrackerCookieDomain);
}
//custom tracking domain
if (etrackerConfig.enableEtrackerProxyDomain) {
script.src = '//' + etrackerConfig.etrackerProxyDomain + '/code/e.js';
}
//default etracker domain
else {
script.src = '//code.etracker.com/code/e.js';
}
script.setAttribute('async', '');
s.parentNode.insertBefore(script, s);
}
Expand Down
31 changes: 31 additions & 0 deletions Template/Variable/EtrackerConfigurationVariable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

use Piwik\Piwik;
use Piwik\Settings\FieldConfig;
use Piwik\Validators\CharacterLength;

Check failure on line 14 in Template/Variable/EtrackerConfigurationVariable.php

View workflow job for this annotation

GitHub Actions / PHPCS 

EtrackerConfigurationVariable.php: Type Piwik\Validators\CharacterLength is not used in this file.
use Piwik\Validators\NotEmpty;

class EtrackerConfigurationVariable extends BaseVariable
Expand Down Expand Up @@ -54,6 +55,36 @@
return trim($value);
};
}),
$this->makeSetting('enableEtrackerProxyDomain', false, FieldConfig::TYPE_BOOL, function (FieldConfig $field) {
$field->title = Piwik::translate('TagManager_EtrackerConfigurationVariableEnableProxyDomainTitle');
$field->description = Piwik::translate('TagManager_EtrackerConfigurationVariableEnableProxyDomainDescription');
}),
$this->makeSetting('etrackerProxyDomain', '', FieldConfig::TYPE_STRING, function (FieldConfig $field) {
$field->condition = 'enableEtrackerProxyDomain';
$field->title = Piwik::translate('TagManager_EtrackerConfigurationVariableProxyDomainTitle');
$field->description = Piwik::translate('TagManager_EtrackerConfigurationVariableProxyDomainDescription');
$field->customFieldComponent = self::FIELD_VARIABLE_COMPONENT;
//$field->validators[] = new NotEmpty();
//$field->validators[] = new CharacterLength(4, 200);
$field->transform = function ($value) {
return trim($value);
};
}),
$this->makeSetting('enableEtrackerCookieDomain', false, FieldConfig::TYPE_BOOL, function (FieldConfig $field) {
$field->title = Piwik::translate('TagManager_EtrackerConfigurationVariableEnableCookieDomainTitle');
$field->description = Piwik::translate('TagManager_EtrackerConfigurationVariableEnableCookieDomainDescription');
}),
$this->makeSetting('etrackerCookieDomain', '', FieldConfig::TYPE_STRING, function (FieldConfig $field) {
$field->condition = 'enableEtrackerCookieDomain';
$field->title = Piwik::translate('TagManager_EtrackerConfigurationVariableCookieDomainTitle');
$field->description = Piwik::translate('TagManager_EtrackerConfigurationVariableCookieDomainDescription');
$field->customFieldComponent = self::FIELD_VARIABLE_COMPONENT;
//$field->validators[] = new NotEmpty();
//$field->validators[] = new CharacterLength(4, 200);
$field->transform = function ($value) {
return trim($value);
};
}),
$this->makeSetting('etrackerBlockCookies', true, FieldConfig::TYPE_BOOL, function (FieldConfig $field) {
$field->title = Piwik::translate('TagManager_EtrackerConfigurationVariableBlockCookiesTitle');
}),
Expand Down
8 changes: 8 additions & 0 deletions lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,14 @@
"EtrackerConfigurationVariableCustTitle": "Variable et_cust",
"EtrackerConfigurationVariableCustomDimensionsTitle": "Custom Dimensions",
"EtrackerConfigurationVariableCustomDimensionsDescription": "Optionally set one or multiple custom dimensions.",
"EtrackerConfigurationVariableEnableProxyDomainTitle": "Enable etracker Tracking Domain",
"EtrackerConfigurationVariableEnableProxyDomainDescription": "Set up custom domain instead of using code.etracker.com",
"EtrackerConfigurationVariableProxyDomainTitle": "Your custom etracker Tracking Domain",
"EtrackerConfigurationVariableProxyDomainDescription": "Use hostname like e.g. 'analytics.domain.com' (without any slashes)",
"EtrackerConfigurationVariableEnableCookieDomainTitle": "Enable etracker Custom Cookie Domain",
"EtrackerConfigurationVariableEnableCookieDomainDescription": "Set up custom cookie domain instead of using www.domain.com",
"EtrackerConfigurationVariableCookieDomainTitle": "Custom Domain for setting cookies",
"EtrackerConfigurationVariableCookieDomainDescription": "Use different domain to set cookies e.g. '.domain.com' (instead of www.domain.com)",
"JavaScriptVariableNameTitle": "JavaScript Variable Name",
"JavaScriptVariableNameDescription": "The name of any variable that is available within the global scope. In case you want to access the value of a nested object, you can access the value of an object by separating each property by a dot, for example \"document.referrer\".",
"MetaContentVariableNameTitle": "Meta Name",
Expand Down
Loading