Skip to content

🐛 Hangup call with MXCallHangupReasonInviteTimeout reason when invite expires #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

🐛 Hangup call with MXCallHangupReasonInviteTimeout reason when invite expires #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa29f11
🐛 Hangup call with MXCallHangupReasonInviteTimeout reason when inivte…
ferologics Jan 21, 2022
068fe80
Add CHANGELOG
ferologics Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions MatrixSDK/VoIP/MXCall.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,25 +1672,12 @@ - (void)expireCallInvite

if (inviteExpirationTimer)
{
[inviteExpirationTimer invalidate];
inviteExpirationTimer = nil;
}

if (!_isIncoming)
{
// Terminate the call at the stack level we initiated
[callStackCall end];
}

// Send the notif that the call expired to the app
[self setState:MXCallStateInviteExpired reason:nil];
Copy link
Contributor

@ismailgulek ismailgulek Jun 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep this state change before sending hangup.


// Set appropriate call end reason
_endReason = MXCallEndReasonMissed;

// And set the final state: MXCallStateEnded
[self setState:MXCallStateEnded reason:nil];

// The call manager can now ignore this call
[callManager removeCall:self];
if (!_isIncoming) { // hang up on the side of the caller (call initiator)
[self hangupWithReason: MXCallHangupReasonInviteTimeout];
}
}

Expand Down
1 change: 1 addition & 0 deletions changelog.d/1341.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
MXCall: Hangup call with MXCallHangupReasonInviteTimeout reason when invite expires