Skip to content

add _directUserId to MXRoomSummary hash function #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

add _directUserId to MXRoomSummary hash function #1683

wants to merge 2 commits into from

Conversation

NikolaevIV
Copy link

@NikolaevIV NikolaevIV commented Jan 16, 2023 •
edited
Loading

Pull Request Checklist

@NikolaevIV
Copy link
Author

NikolaevIV commented Jan 17, 2023 •
edited
Loading

When you first call public func fetcherDidChangeData(_ fetcher: MXRoomListDataFetcher, totalCountsChanged: Bool)
from MXRoomListDataFetcherDelegate, the directUserId value of the first room in the fetcher object is nil.

@IgorFedorchuk @NikolaevIV
add _directUserId to MXRoomSummary hash function
b9392aa 
Signed-off-by: Игорь Николаев <[email protected]>
@ddimpalass ddimpalass deleted the fedorchuk/fix_hash branch February 1, 2023 08:54
@IgorFedorchuk IgorFedorchuk restored the fedorchuk/fix_hash branch September 4, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@IgorFedorchuk IgorFedorchuk IgorFedorchuk approved these changes

@korrespondentios korrespondentios korrespondentios approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NikolaevIV @IgorFedorchuk @korrespondentios