Conversation
kelemeno
requested review from
StanislavBreadless and
vladbochok
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| bytes32 bytecodeHash, | ||
| uint32 bytecodeLength, | ||
| bytes32 observableBytecodeHash, | ||
| uint32 observableBytecodeLength | ||
| ) = abi.decode(_bytecodeInfo, (bytes32, uint32, bytes32, uint32)); |
There was a problem hiding this comment.
The new unsafeForceDeployZKsyncOS decodes _bytecodeInfo into four fields, including an observableBytecodeLength, but ZKSyncOSBytecodeInfo.encodeZKSyncOSBytecodeInfo (used to build these blobs in deploy-scripts) still emits only three values (Blake hash, length, observable hash). Any upgrade/genesis path that passes the existing encoded data will now revert on the abi.decode before calling the deployer, breaking ZKsync OS force deployments.
Useful? React with 👍 / 👎.
|
Closing in favour of Raid's PR |
1 participant
What ❔
Why ❔
Checklist